- May 13, 2019
-
-
Marty Faltesek authored
ZX-3736 Test: stack-test Change-Id: Ib7a55021bf5790352a451a34a5cad1e74fda780b
-
Garratt Gallagher authored
This updates the ISP test fidl interface to comply with abarth's fidl rules. TEST: No functionality change. Change-Id: I6660a9bf47e66ba7337c95245f9e7ade5f9dfb3d
-
Andres Oportus authored
Change-Id: If6d9f751f9beadf51bddd584eb3f8cb7d5511ef7
-
Francois Rousseau authored
* apparently RunLoopWithTimeoutUntil() is bad because the default timeout isn't guaranteed to be enough on some bots so instead we rely on the infra timeout they give to each test * we don't check the return value RunLoopUntil() in anticipation of https://fuchsia-review.googlesource.com/c/fuchsia/+/280471 TESTED=`fx run-test feedback_agent_tests` TESTED=`fx run-test crashpad_agent_tests` Change-Id: I491252ef6a3e3f51f418ef5e57d3f426411e54f6
-
Ross Wang authored
This changed from RGBA in https://github.com/brendan-duncan/image/commit/f3d07a74d17d0004d88fc1043042df9111eb3b6f Also added a test for this regression. Issue: https://github.com/brendan-duncan/image/issues/92 Test: fx run-host-tests sl4f_client_tests end-to-end test Change-Id: If8c82f9d5479d16e7c41845eb001d6ac8068ea27
-
Roland McGrath authored
Step #1's local testing was misconfigured and failed to test the step #2 integration build properly as the bots do, so a trivial bug slipped through. Bug: ZX-3365 Change-Id: I331b3b989125c5982632d310daa8b7d512a49faf
-
Aaron Green authored
This CL extends the host test for host fuzzers to also run the python unit tests for 'fx fuzz'. Bugs: SEC-170 Test: fx set core.x64 --with //src/fuzzing:tests fx run-host-test fuzzing_host_test Change-Id: Ic2568e5603b34d35a94ebe85161f476f7854c330
-
James Robinson authored
We use the __TA_xxx macros to annotate code for clang's thread safety analysis features. The thread safety analysis feature works by comparing the annotations on types with the annotations on code using those types and generating a warning if the code is identified that is inconsistent with the annotations or the defined semantics of the annotations. We frequently use these annotations to describe the relationship between code and types from the C++ standard library, such as std::mutex. These types are annotated in the libc++ standard library implementation if the preprocessor define _LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS is set. In the Fuchsia build, we always set -Wthread-safety and -D_LIBCPP_... compiler flags together so the annotations are consistent internally. Some SDK customers use the fuchsia SDK and -Wthread-safety flag without setting the preprocessor define as they use other libraries which use the C++ standard library types in ways incompatible with thread safety analysis. This causes issues when compiling code that uses the __TA_xxx macros with types like std::mutex. This updates the __TA_xxx macros to only enable annotations if we can tell that C++ standard library types are annotated (using the _LIBCPP_... macro) or if we're in kernel code that we always control. This also updates zircon/kernel code to use the non-public macros defined in zircon/system/private so that they are enabled even when libc++ is not involved. ZX-4091 #done Change-Id: I74910f6963d79bd2a53cf5d89a183252c5b58e7e
-
Allan MacKinnon authored
Tracked by SPN-19. Testability: HotSort library and test compile and run. Change-Id: I6a80c97057493c3f967cc4eef30691e82d18ad16
-
Allan MacKinnon authored
Tracked by SPN-22 and SPN-19. Blocks tests SPN-17, SPN-18. Change-Id: I4bd95681b26b81e3521c518b4d0894730e5c23ce
-
Allan MacKinnon authored
Tracked by SPN-19. Testability: not yet part of build. Change-Id: I04c73606b03191d2c6e4f2048f329af848c8f5fb
-
Todd Eisenberger authored
The double free would occur if 1) some thread invoked Cancel() to queue destruction of a ProxyIostate, and 2) before that packet was processed, the ProxyIostate's handler ran and decided to destroy itself. Bug: ZX-4060 Change-Id: I3b9c7275c4e0cd2dc3a6c6cd2d2376c947eb627a
-
Todd Eisenberger authored
This moves the ProxyIostate and ConnectionDestroyer types into their own files, and feeds them async dispatchers via injection rather than environmental globals. Change-Id: Ifeadbed02e92a7e2a7af5346ddd253af74112abf
-
Roland McGrath authored
Bug: ZX-4099 #done Change-Id: I23e6d4b163ddc8616a22decc2029424888305cdf
-
Manali Bhutiyani authored
In order to make the code more encapsulated , this change removes the "friend" relation between fsck and minfs class as well as inode-manager class. We use the interfaces added as part of inspector changes and instead of fsck directly accessing the private members, we use these Interfaces instead. Testing: No behavior change. Merely converted private members to be accessed via public interfaces instead of directly via friend relation. Change-Id: I8fae7acf6d59b47ad2c3376a91d602a127e34de7
-
Francois Rousseau authored
to reflect the absence of timeout: * update the function comment * update the return value to void as it will wait an infinite time for the condition to become true Change-Id: I157d42ecf35b26abcb738690d55439d0271dc32a
-
Gabriel Schine authored
Change-Id: Ie192ad3f1e6734a50cc5e125ac42420be9fae39d
-
Arman Uguray authored
We now process both directed and undirected connectable advertisements when deciding to auto-connect to a bonded peer. This is consistent with the "Auto Connection Establishment Procedure" behavior described in v5.1 Vol 3, Part C, 9.3.5.1. Bug: BT-800 #done Test: 1. bt-host-unittests 2. Auto-connecting to a Microsoft Designer Mouse should succeed all the time. Change-Id: Ied65930588085ff48eb8b15af7f82decd7954ad8
-
Jerry Belton authored
Bug: DX-538 Testing: * sdk archive builds correctly. * workspace generated properly * tests pass as long as I use the same version of bazel that infra uses (0.17.2) Change-Id: I808d1e6ca9d66b56ba6ad8f2e3a06270fd49c79d
-
Jerry Belton authored
Bug: DX-537 Testing: * sdk archive builds correctly. * workspace generated properly * Tests pass if I use the same version of bazel as infra (0.17) Change-Id: I185546362facc44cc7b94e9fd59456b9c6ede49a
-
Konstantin Pozin authored
- Introduce tables for existing structs - Improve organization of definitions; add detailed documentation - Place all new definitions in provider.fidl (and styles.fidl) - Incorporate other changes and suggestions from https://fuchsia-review.googlesource.com/c/fuchsia/+/249522/ Implementation updates will be completed in subsequent CLs. I18N-12 #comment Change-Id: I177f5850b1c9eb91f59af1885005336121c0f1e0
-
Taylor Cramer authored
This change introduces an API to make it easier to assert that a request or event is of a particular type. This change also moves one test over to demonstrate how tests can take advantage of the API. Change-Id: Iae0c93164d04e806e7fc64abe6ba2bd45b3aa383
-
Derek Gonyeo authored
The current implementation of the storage watchdogs checks usage against minfs allocation size, whereas it should be checking it against the maximum size of the partition. CF-736 #comment Change-Id: Ice62267d9d3dadd076745d4b87c42aef734b6882
-
Roland McGrath authored
The libc++ support changes refactored the GN magic around the vDSO ($zx/system/ulib/zircon) target and broke the semantics for derived environments of the user environment, i.e. user.fuzzer. Fix that. Bug: BLD-430 #comment Fix GN build regression introduced by libc++ support. Bug: ZX-1751 #comment Fix GN build regression introduced by libc++ support. Change-Id: I47bd7683e97aedb7b2ab7c8ab05a136cd936ff26
-
Doug Evans authored
Change-Id: I960886bae1a318c96153c0ce69b90d0a55c6ee38
-
Dave Schuyler authored
To improve testing of the full path of the data, this CL adds a query for the device memory to the dockyard_host. It does so by setting up proper callbacks and waiting for the device connection prior to making the request. Bug: 9 Test: dockyard_host_test Change-Id: I334a99a2190ce7eab849b9742cce5d92b205ad5a
-
Justin Mattson authored
Forgot to remove the request for /system/data from the CMX previously. TEST=none, removing unused request Change-Id: I7c22dffbd188e8bb94a5dba9914252a2aa5e7760
-
Miguel Flores Ruiz de Eguino authored
MI4-2399 #done TESTED=build Change-Id: I349581101aa35e29e14dee3058b62bcde963cbd9
-
Cristián Donoso authored
This makes it easier to fine grain debug messages. Added timing statements to loading modules, as this is the cause of a latest timing regression. Change-Id: I964d1083414d278b12ff2f97aaf609c76f24be39
-
Doug Evans authored
Change-Id: I5b8d1f7e36d26df7087d67881614b228fa58b471
-
Cristián Donoso authored
TEST=unit Change-Id: I95bc9a9b73387ea4a2b06cce212a1b8b8a8b4ad8
-
Erick Tryzelaar authored
Change-Id: I617cd65bd6612651e48d6cb2e1d3fae450275909
-
Sean Klein authored
Change-Id: I8cd0ba4f4ae1af47271462a6da8ddcd7813a19d8
-
Justin Mattson authored
This makes the example `cat` output consistent between two example iterations. TEST=none, just docs Change-Id: Ib92f3043b0b50c649805da5f5119d78e42eed15f
-
Tamir Duberstein authored
This restores most of the incidental improvements in the original commit 396d2162, while keeping logging silent. This reverts commit 7f7e4ffb. Change-Id: Ie8183448c8cddb03f0423287d67183b0a3658cf6
-
Ambre Williams authored
This change adds the ability for the rust cloud provider to simulate network errors. The next CL will add a mechanism for externally controlling the network state. TEST=unit tests in crate::session::tests Change-Id: Ia329e7cf802054cce73d35bf505677a9577eb8d8
-
docs-roller authored
Test: CQ Change-Id: Iec3c3e3c83bab280fc73ca4c5d2e87305d1a1666
-
Jaeheon Yi authored
fuchsia.ui.views.Event is unused. Delete it. fuchsia.ui.views.Command is part of fuchsia.ui.scenic.Command. Keep it for ABI stability, but mark it as obsolete. TEST=CQ Change-Id: Ice82aeaa614563bacb62126718f1d42bcf197aad
-
Jaeheon Yi authored
The INFO logs are very, very chatty. Reduce some of the clutter. TEST=CQ Change-Id: Iff741fca5c8c697a242bbea512f76e6ae3b43068
-
Jaeheon Yi authored
Design has changed, and this is no longer useful code. SCN-1124 #comment TEST=CQ Change-Id: Ia19f4cdeb3a3f263bd022bd3efdf8a5a8b675d6b
-